RFR: 8273635: Attempting to acquire lock StackWatermark_lock/9 out of order with lock tty_lock/3

Coleen Phillimore coleenp at openjdk.java.net
Mon Sep 13 20:15:24 UTC 2021


This change reverts the rank ordering of ttyLock and StackWatermark_lock because the latter is held through a very large region and printing all of this to a buffer with xmlstream is non-trivial.
With this change, if tty->print_cr() is done while holding the stackwatermark lock or lower (which is service ranking, etc), a lock inversion will happen with ttyLock.  This doesn't happen now because all the code in GC and much of the rest of the runtime use UL and not tty->print().
Tested with tier1-6.

-------------

Commit messages:
 - 8273635: Attempting to acquire lock StackWatermark_lock/9 out of order with lock tty_lock/3

Changes: https://git.openjdk.java.net/jdk/pull/5499/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5499&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8273635
  Stats: 5 lines in 2 files changed: 1 ins; 1 del; 3 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5499.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5499/head:pull/5499

PR: https://git.openjdk.java.net/jdk/pull/5499


More information about the hotspot-dev mailing list