RFR: JDK-8271567: AArch64: AES Galois CounterMode (GCM) interleaved implementation using vector instructions [v8]

Andrew Haley aph at openjdk.java.net
Tue Sep 14 16:01:14 UTC 2021


On Tue, 14 Sep 2021 04:34:06 GMT, Xin Liu <xliu at openjdk.org> wrote:

>> Andrew Haley has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Whitespace
>
> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 3001:
> 
>> 2999:     assert(bulk_width == 4 || bulk_width == 8, "must be");
>> 3000: 
>> 3001:     if (bulk_width == 8) {
> 
> `bulk_width` is defined as a constant 4.  why do you also check bulk_width == 8? 
> is this parameter tunable?  same as "const int unroll = 4" below.

Comment added.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5390


More information about the hotspot-dev mailing list