RFR: JDK-8271567: AArch64: AES Galois CounterMode (GCM) interleaved implementation using vector instructions [v8]

[Andrew Haley]

On Tue, 14 Sep 2021 07:48:03 GMT, Xin Liu <xliu at openjdk.org> wrote:

>> Andrew Haley has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Whitespace
>
> src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp line 1300:
> 
>> 1298:         Register tmp3);
>> 1299: 
>> 1300:   void ghash_modmul_wide (int index, FloatRegister result,
> 
> Is there definition and reference of this?

Removed.

> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 2863:
> 
>> 2861:     //
>> 2862:     // int result = len;
>> 2863:     // while (len-- > 0) {
> 
> I see that algorithm code comes from CounterMode.implCrypt, but  while (len-- > 0) seems not to be exactly same as algorithm here. I think it should be `while (len > 0)`
> 
> `blockSize()` at line 2865 should be `blockSize`

Done.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5390