RFR: 8271073: Improve testing with VM option VerifyArchivedFields [v2]
Calvin Cheung
ccheung at openjdk.java.net
Wed Sep 15 17:06:50 UTC 2021
On Wed, 15 Sep 2021 17:02:06 GMT, Ioi Lam <iklam at openjdk.org> wrote:
>> - Changed the definition of `VerifyArchivedFields` from a whacky use of `bool` to an `int` and properly define its three levels:
>> - 0: No verification
>> - 1: Basic verification with VM_Verify (no side effects)
>> - 2: Detailed verification by forcing a GC (with side effects)
>> - Changed the default value to 0. The functionality checked by this flag has been very stable so there's no need to verify it in every single test case.
>> - Enabled `-XX:VerifyArchivedFields=1` for all CDS test cases.
>> - Added a new test case for `-XX:VerifyArchivedFields=2` .
>> - Also added comments about that this flag is suppose to check for.
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>
> the test should require vm.cds.write.archived.java.heap
Looks good.
-------------
Marked as reviewed by ccheung (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/5514
More information about the hotspot-dev
mailing list