RFR: 8273928: Use named run ids when problem listing tests [v3]

David Holmes dholmes at openjdk.java.net
Sun Sep 19 23:23:51 UTC 2021


On Sat, 18 Sep 2021 19:02:11 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Stefan Karlsson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix TestReferenceClearDuringReferenceProcessing
>
> test/hotspot/jtreg/ProblemList.txt line 104:
> 
>> 102: runtime/InvocationTests/invokevirtualTests.java#old-int 8271125 generic-all
>> 103: runtime/jni/terminatedThread/TestTerminatedThread.java 8219652 aix-ppc64
>> 104: runtime/os/TestTracePageSizes.java#no-options               8267460 linux-aarch64
> 
> I don't think the whitespace changes to align fields should be made.  That's not the style of this file.  And I think it shouldn't be the style, since maintaining the alignment will frequently introduce otherwise uninteresting diffs.

I agree with Kim.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5557


More information about the hotspot-dev mailing list