RFR: 8273928: Use named run ids when problem listing tests [v4]
Stefan Karlsson
stefank at openjdk.java.net
Mon Sep 20 11:22:40 UTC 2021
> Today when you have multiple jtreg run sections in a test, each run gets an automated id that match the location in the file. For example:
> Passed: gc/stringdedup/TestStringDeduplicationAgeThreshold.java#id0
> Passed: gc/stringdedup/TestStringDeduplicationAgeThreshold.java#id1
> Passed: gc/stringdedup/TestStringDeduplicationAgeThreshold.java#id2
> Passed: gc/stringdedup/TestStringDeduplicationAgeThreshold.java#id3
>
> The path to the test plus the id can be used to problem lists the test. Say that id3 matches a run done with ZGC, and we need to problem list this test with ZGC, then the problem list would contain:
> gc/stringdedup/TestStringDeduplicationAgeThreshold.java#id3
>
> The problem is when someone adds a new run section before that, then all the ids will be shifted and #id3 doesn't correspond to the ZGC run anymore. A similar problem occurs if two run sections are swapped.
>
> I propose that we refrain from using the automatically generated ids when problem listing tests. Instead we add explicit ids like this:
> * @test id=Z
>
> An additional benefit of doing this is that it will be easier to see what was actually run:
> Passed: gc/stringdedup/TestStringDeduplicationAgeThreshold.java#G1
> Passed: gc/stringdedup/TestStringDeduplicationAgeThreshold.java#Parallel
> Passed: gc/stringdedup/TestStringDeduplicationAgeThreshold.java#Serial
> Passed: gc/stringdedup/TestStringDeduplicationAgeThreshold.java#Z
>
> I've gone through the tests in the HotSpot problem lists + some that affects ZGC. There are probably more tests that would benefit from getting explicit ids, but I started with a small set to begin with.
Stefan Karlsson has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
- Merge remote-tracking branch 'origin/master' into 8273928_jtreg_ids
- Review 1
- Fix TestReferenceClearDuringReferenceProcessing
- Remove temporary ProblemList testing
- 8273928: Use named run ids when problem listing tests
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/5557/files
- new: https://git.openjdk.java.net/jdk/pull/5557/files/5129ed8e..363e17fb
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=5557&range=03
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=5557&range=02-03
Stats: 1780 lines in 64 files changed: 1193 ins; 445 del; 142 mod
Patch: https://git.openjdk.java.net/jdk/pull/5557.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/5557/head:pull/5557
PR: https://git.openjdk.java.net/jdk/pull/5557
More information about the hotspot-dev
mailing list