RFR: 8274024: Use regular accessors to internal fields of oopDesc

David Holmes dholmes at openjdk.java.net
Tue Sep 21 05:55:50 UTC 2021


On Mon, 20 Sep 2021 18:59:34 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

> Currently, we are using 'raw' accessors to initialize the mark, Klass*, (array-)length and klass_gap of oops. This is ugly and confusing and we should just use the regular accessors.
> 
> Testing:
>  - [ ] tier1
>  - [ ] tier2
>  - [ ] hotspot_gc

Hi Roman,

This seems semantically wrong to me. Until we have applied all these operations to the raw "mem" we don't have an Oop, we just have a chunk of memory that is being transformed into an oop. Should these operations instead be combined into a factory method that takes raw "mem" and returns an oop, rather than having setters for these internal fields?

Thanks,
David

-------------

PR: https://git.openjdk.java.net/jdk/pull/5585


More information about the hotspot-dev mailing list