RFR: 8186670: Implement _onSpinWait() intrinsic for AArch64 [v2]

[Andrew Haley]

On Mon, 20 Sep 2021 16:21:38 GMT, Evgeny Astigeevich <github.com+42899633+eastig at openjdk.org> wrote:

>> This PR is a follow-up on the discussion [“RFC: AArch64: Implementing spin pauses with ISB”](https://mail.openjdk.java.net/pipermail/hotspot-dev/2021-August/054033.html).
>> 
>> It adds the option `UsePauseImpl=value`, where `value` can be:
>> 
>> - `none`: no implementation for spin pauses. This is the default value.
>> - `Nnop`: use `nop` instruction for spin pauses. Optional `N` can be `2..9` to specify a number of `nop` instructions.
>> - `Nisb`: use `isb` instruction for spin pauses. Optional `N` can be `2..9` to specify a number of `isb` instructions.
>> - `Nyield`: use `yield` instruction for spin pauses. Optional `N` can be `2..9` to specify a number of `yield` instructions.
>> 
>> The code for the `Thread.onSpinWait` intrinsic is generated based on the value of `UsePauseImpl`.
>> 
>> Testing:
>> 
>> - `make test TEST="gtest"`: Passed
>> - `make run-test TEST="tier1"`: Passed
>> - `make run-test TEST="tier2"`: Passed
>> - `make run-test TEST=hotspot/jtreg/compiler/onSpinWait`: Passed
>
> Evgeny Astigeevich has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Replace 'for' loops with macros

src/hotspot/cpu/aarch64/aarch64.ad line 14374:

> 14372:         ShouldNotReachHere();
> 14373:     }
> 14374:     #undef EMIT_N_ASM_STRINGS

None of this is necessary. Printing "onspinwait" is enough.

src/hotspot/cpu/aarch64/aarch64.ad line 14392:

> 14390:         ShouldNotReachHere();
> 14391:     }
> 14392:   %}

Please let the MacroAssembler do this. Just call `MacroAssembler::spin_wait()`.

src/hotspot/cpu/aarch64/c1_LIRAssembler_aarch64.cpp line 2999:

> 2997:       break;
> 2998:     default:
> 2999:       ShouldNotReachHere();

Same here. Please just call `MacroAssembler::spin_wait()`.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5562