RFR: 8273916: Remove 'special' ranking [v3]
Coleen Phillimore
coleenp at openjdk.java.net
Tue Sep 21 23:47:46 UTC 2021
On Tue, 21 Sep 2021 21:50:27 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:
>> Coleen Phillimore has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits:
>>
>> - Remove blank line.
>> - Merge branch 'master' into remove-special
>> - Add comment about ThreadSMRDelete_lock
>> - Remove "special" rank.
>> - Partition safepoint checking and nonchecking lock ranks. The nonchecking locks are always lower ranked than the safepoint checking locks because they cannot block.
>> - Partition safepoint checking and nonchecking lock ranks. The nonchecking locks are always lower ranked than the safepoint checking locks because they cannot block.
>
> src/hotspot/share/runtime/mutexLocker.cpp line 228:
>
>> 226: def(StringDedupIntern_lock , PaddedMutex , nosafepoint, true, _safepoint_check_never);
>> 227: def(ParGCRareEvent_lock , PaddedMutex , leaf, true, _safepoint_check_always);
>> 228: def(CodeCache_lock , PaddedMonitor, nosafepoint-3, true, _safepoint_check_never);
>
> nit: There is a comment in mutexLocker.hpp that rank of CodeCache_lock is special.
Thanks for noticing that.
-------------
PR: https://git.openjdk.java.net/jdk/pull/5563
More information about the hotspot-dev
mailing list