RFR: 8274325: C4819 warning at vm_version_x86.cpp on Windows after JDK-8234160 [v2]

Jie Fu jiefu at openjdk.java.net
Mon Sep 27 03:58:58 UTC 2021


> Hi all,
> 
> I'd like to fix the C4819 warning at vm_version_x86.cpp on Windows after JDK-8234160.
> 
> The reason is that there are non-ASCII chars in the comments of vm_version_x86.cpp after JDK-8234160.
> It makes the code to be less portable.
> 
> It would be better to fix it.
> 
> The fix just removing those chars in the comments.
> 
> Thanks.
> Best regards,
> Jie

Jie Fu has updated the pull request incrementally with one additional commit since the last revision:

  Use (R) and (TM)

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/5701/files
  - new: https://git.openjdk.java.net/jdk/pull/5701/files/9e7a1cfe..5b3ea4bf

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=5701&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=5701&range=00-01

  Stats: 37 lines in 1 file changed: 0 ins; 0 del; 37 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5701.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5701/head:pull/5701

PR: https://git.openjdk.java.net/jdk/pull/5701


More information about the hotspot-dev mailing list