RFR: 8274325: C4819 warning at vm_version_x86.cpp on Windows after JDK-8234160 [v2]

David Holmes dholmes at openjdk.java.net
Mon Sep 27 06:12:09 UTC 2021


On Mon, 27 Sep 2021 03:58:58 GMT, Jie Fu <jiefu at openjdk.org> wrote:

>> Hi all,
>> 
>> I'd like to fix the C4819 warning at vm_version_x86.cpp on Windows after JDK-8234160.
>> 
>> The reason is that there are non-ASCII chars in the comments of vm_version_x86.cpp after JDK-8234160.
>> It makes the code to be less portable.
>> 
>> It would be better to fix it.
>> 
>> The fix just removing those chars in the comments.
>> 
>> Thanks.
>> Best regards,
>> Jie
>
> Jie Fu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use (R) and (TM)

Looks good and trivial.

Thanks,
David

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5701


More information about the hotspot-dev mailing list