RFR: 8274322: Problems with oopDesc construction [v2]

[Kim Barrett]

On Wed, 29 Sep 2021 04:13:19 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Kim Barrett has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   dholmes review
>
> src/hotspot/share/oops/oop.hpp line 35:
> 
>> 33: #include "runtime/atomic.hpp"
>> 34: #include "utilities/macros.hpp"
>> 35: #include "utilities/globalDefinitions.hpp"
> 
> Nit: not included in alphabetic order (and it will include macros.hpp itself anyway).

Fixed the order.  In the interest of "include what you use" I left macros.hpp in the list.

> src/hotspot/share/oops/oop.hpp line 326:
> 
>> 324: // the Java heap, and static functions provided here on HeapWord* are used
>> 325: // to fill in certain parts of that memory.  For that to be valid, the
>> 326: // object must not have non-trivial initialization (C++14 3.8).  For that to
> 
> Can we avoid the double-negative and state it "must have trivial initialization"?

I've improved the wording, including eliminating the double negative.  I followed the wording in the standard a little too closely; that's where "non-trivial initialization" came from. I think "must have trivial initialization" isn't right, since "initialization" in this context involves invocation of a constructor, and we're dealing with a case where that doesn't happen.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5729