RFR: 8274501: c2i entry barriers read int as long on AArch64

Aleksey Shipilev shade at openjdk.java.net
Wed Sep 29 16:41:29 UTC 2021


On Wed, 29 Sep 2021 15:12:40 GMT, Erik Österlund <eosterlund at openjdk.org> wrote:

> There was a bug in the x86_64 implementation of the c2i entry barriers. We read the CLD::_keep_alive int as a 64 bit integer, while it is of course in fact a 32 bit integer. It was fixed in the patch that ported it to x86_32 (JDK-8235262). However, somewhere in-between I think the wrong code was used as a basis for the AArch64 implementation, which now seemingly has inherited that same bug.

Looks good! 

I suspect PPC has the same problem, @TheRealMDoerr, @GoeLin?

-------------

Marked as reviewed by shade (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5754


More information about the hotspot-dev mailing list