RFR: 8283710: JVMTI: Use BitSet for object marking [v5]
Thomas Stuefe
stuefe at openjdk.java.net
Thu Apr 7 17:51:44 UTC 2022
On Thu, 7 Apr 2022 17:22:12 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
>> Roman Kennke has updated the pull request incrementally with four additional commits since the last revision:
>>
>> - Add comment describing ObjectBitSet
>> - Refactor JVMTI usage of ObjectBitSet
>> - Typedef ObjectBitSet<mtTracing> to JFRBitSet in JFR code
>> - Rename BitSet to ObjectBitSet
>
> src/hotspot/share/jfr/leakprofiler/chains/bfsClosure.hpp line 37:
>
>> 35: class ObjectBitSet;
>> 36:
>> 37: typedef ObjectBitSet<mtTracing> JFRBitSet;
>
> Can you include memory/allocation.hpp for the MEMFLAGS? iterator.hpp already does, but better to be include-clean
Optional: move this typedef to an own jfr/leakprofiler/utilities/jfrbitset.hpp and include that one instead of objectbitset.inline.hpp in the callee cpp files
-------------
PR: https://git.openjdk.java.net/jdk/pull/7964
More information about the hotspot-dev
mailing list