RFR: 8282528: AArch64: Incorrect replicate2L_zero rule [v2]

Eric Liu eliu at openjdk.java.net
Mon Apr 11 12:27:43 UTC 2022


On Fri, 8 Apr 2022 09:09:18 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Eric Liu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix comment
>>   
>>   Change-Id: Ic51820391d19b61e37847cc04375ecd79fc86779
>
> src/hotspot/cpu/aarch64/aarch64_neon_ad.m4 line 1571:
> 
>> 1569:             `$3 $4', `I _imm', ` '$con$$constant,
>> 1570:             `$3 $4', `L _imm', ` '$con$$constant,
>> 1571:             `$6', vRegF,`
> 
> This `ifelse` is rather confusing. Can't the '& 0xff' be passed as arguments into `VREPLICATE`?

Done. I think these rules should not have been merged by force. It's hard to maintain.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7939


More information about the hotspot-dev mailing list