RFR: 8280761: UseCompressedOops should be set after limit_heap_by_allocatable_memory [v3]

Thomas Schatzl tschatzl at openjdk.java.net
Mon Apr 11 13:36:52 UTC 2022


On Mon, 11 Apr 2022 08:43:41 GMT, KIRIYAMA Takuya <duke at openjdk.java.net> wrote:

>> This looks like an additional (unrelated) test to make sure it is overridden if necessary imho. It seems a bit forced though because there is no test that actually verifies that `UseCompressedOops` is `false` later.
>> I'm good with removing the test case.
>
>> This looks like an additional (unrelated) test to make sure it is overridden if necessary imho.
> 
> That is correct.  
> Do you mean that the following code should be removed?  
> 
> `checkFlag(128 * oneG, 100, true, true);`

Yes. Removing this test case would limit the testing to the actual problem stated in the CR. Verifying that `UseCompressedOops` is enabled correctly is tested somewhere else already, and there is no reason that using `ulimit -v` would change that behavior.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7938


More information about the hotspot-dev mailing list