RFR: JDK-8283326: Implement SafeFetch statically

Thomas Stuefe stuefe at openjdk.java.net
Tue Apr 12 09:36:42 UTC 2022


On Tue, 12 Apr 2022 02:37:05 GMT, David Holmes <dholmes at openjdk.org> wrote:

> > On Posix platforms you can use either static assembly or setjmp, and need to exclude one of them from compilation - either build safefetch_xx_xx.S, or build safefetch_sigjmp.cpp.
> 
> Yes but we don't need to make this build time selectable. If a platform supports static then it will have a .S file and won't use the sigjmp file (which will be empty due to ifdef based on platform); otherwise no .S file and the sigjmp file is populated.
> 

How would this work? You would add a "#if defined(zero) && defined(aix) &&..." to safefetch_sigjmp.cpp? 

I honestly find this less readable and grep-able than now...

-------------

PR: https://git.openjdk.java.net/jdk/pull/7865


More information about the hotspot-dev mailing list