RFR: JDK-8283326: Implement SafeFetch statically

David Holmes dholmes at openjdk.java.net
Tue Apr 12 10:23:52 UTC 2022


On Mon, 11 Apr 2022 06:21:19 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> src/hotspot/os/posix/vmError_posix.cpp line 79:
>> 
>>> 77: 
>>> 78: #if defined(SAFEFETCH_METHOD_STATIC_ASSEMBLY) || defined(SAFEFETCH_METHOD_SIGSETJMP)
>>> 79:   // Handle safefetch here too, to be able to use SafeFetc() inside the error handler
>> 
>> Typo: SafeFetc()
>
> Ditto regarding whether the guard is needed.

Again this code is effectively unconditional - the ifdefs are not needed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7865


More information about the hotspot-dev mailing list