RFR: JDK-8283326: Implement SafeFetch statically

Thomas Stuefe stuefe at openjdk.java.net
Tue Apr 12 10:42:33 UTC 2022


On Tue, 12 Apr 2022 10:19:59 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> src/hotspot/os/posix/signals_posix.cpp line 614:
>> 
>>> 612:   }
>>> 613: 
>>> 614: #if defined(SAFEFETCH_METHOD_STATIC_ASSEMBLY) || defined(SAFEFETCH_METHOD_SIGSETJMP)
>> 
>> The guard seems unnecessary - all posix platforms need to handle safefetch here don't they?
>
> Sorry how is this "resolved". Every posix platform will define one of those cases so this code is effectively unconditional.

I use "resolved" to mark my internal progress, which you may not see yet since I did not push yet. Probably should not use "resolve".

-------------

PR: https://git.openjdk.java.net/jdk/pull/7865


More information about the hotspot-dev mailing list