RFR: 8284274: Error reporting crashes because missing ResourceMarks
David Holmes
dholmes at openjdk.java.net
Tue Apr 12 13:30:43 UTC 2022
On Tue, 12 Apr 2022 12:01:15 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
> Taking the suggestion from @stefank in the bug report, disable the ResourceMark missing assert during error reporting. There's a ResourceArea in the thread that can be used. Added a test.
> Tested with tier1-4 on x86 and aarch64 platforms.
Hi Coleen,
Looks good!
One query below.
Thanks,
David
src/hotspot/share/utilities/vmError.cpp line 550:
> 548: // error handler after a secondary crash works.
> 549: STEP("test secondary crash 1")
> 550: if (_verbose && TestCrashInErrorHandler == 14) {
Where does the 14 come from ??
-------------
Marked as reviewed by dholmes (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/8201
More information about the hotspot-dev
mailing list