RFR: 8284274: Error reporting crashes because missing ResourceMarks

Coleen Phillimore coleenp at openjdk.java.net
Tue Apr 12 14:22:50 UTC 2022


On Tue, 12 Apr 2022 14:19:02 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> See runtime/ErrorHandling/SecondaryErrorTest.java, it is fed into VMError::controlled_crash().
>> 
>> That test crashes the VM first with one signal, then inside the error handler with a second, different, signal, to test that the second error signal was correctly unblocked or left unblocked. Otherwise, the VM would just disappear.
>
> Yes, the 14 comes with the test.  Nothing else queries the value of TestCrashInErrorHandler or passes anything but 14 or now in my test, 2.

We could change the 14 to the first test to some enum test_error_handler { secondary_crash = 1, resource_mark_crash = 2 }; and change the test.  I just left the 14 since the test can't see the enum values.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8201


More information about the hotspot-dev mailing list