RFR: 8284274: Error reporting crashes because missing ResourceMarks [v2]
Coleen Phillimore
coleenp at openjdk.java.net
Tue Apr 12 19:38:51 UTC 2022
On Tue, 12 Apr 2022 16:15:50 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Add some variable names for test values.
>
> test/hotspot/jtreg/runtime/ErrorHandling/ResourceMarkTest.java line 64:
>
>> 62: output_detail.shouldMatch("#.+SIGFPE.*");
>> 63: output_detail.shouldMatch("This is a message with no ResourceMark");
>> 64:
>
> Note that we introduced -XX:+ErrorFileToStdout and -XX:+ErrorFileToStderr, you could use that instead of looking for the hs-err file, and parse output_detail directly for the strings in question. The ErrorHandler tests are older than those switches and could be rewritten too.
Ha Thomas, I copied your test almost verbatim. If I send all the hs_err file to stdout, jtreg might truncate it and that won't help, also if the test someday fails, the output will be lost in the jtreg truncation. Having two test do sort of the same thing seemed nice to me.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8201
More information about the hotspot-dev
mailing list