RFR: JDK-8283326: Implement SafeFetch statically [v4]

[Thomas Stuefe]

On Tue, 12 Apr 2022 17:42:16 GMT, Anton Kozlov <akozlov at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - fix indentations
>>  - extend gtests to test with -1 as default value
>
> src/hotspot/share/runtime/safefetch.hpp line 30:
> 
>> 28: 
>> 29: #include "utilities/macros.hpp"
>> 30: 
> 
> Sorry, found late. This file now lacks the interface and description from the former safefetch.inline.hpp https://github.com/openjdk/jdk/blob/19b140a7f30ea600d66bcf8370d94f5d6bf6d0d1/src/hotspot/share/runtime/safefetch.inline.hpp#L35. A reader would need to look at the implementation files and assume they provide consistent interface. 
> 
> This seems not trivial just to provide declarations because in different implementation has C++ or C linkage. I can only imagine to make e.g. SafeFetch32 to call SafeFetch32_impl that may have any linkage, be inline or extern, etc.

Yes, this bugged me too. I tried to keep the windows implementations inline. Your proposal makes sense, I'll do that.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7865