RFR: 8242440: use separate, destroyable JavaVM instances per libgraal compiler thread

Doug Simon dnsimon at openjdk.java.net
Mon Apr 18 09:22:34 UTC 2022


On Mon, 18 Apr 2022 04:45:24 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Thanks for the reminder. I'm tempted to now change `NULL` to `nullptr` in all `jvmci/*` files. What's the policy/recommendation on that? Don't bother/separate PR/piggy-back on this PR?
>
> I think most folks have been taking a nullptr in new code approach, without anyone doing substantial conversions.  Though Leo did look at a wholesale conversion at one point (it turned out to be a little premature, since we didn't really have nullptr yet).  There are some places where there are strange overload games being played because NULL is an unadorned `0` on some platforms, and I think Leo found some places where the selected overload was even wrong because of that.  I certainly wouldn't a wholesale conversion of JVMCI as part of this PR.

Ok, I'll take this opportunity to convert some JVMCI code to `nullptr` and do more in subsequent PRs.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8262


More information about the hotspot-dev mailing list