RFR: 8282477: [x86, aarch64] vmassert(_last_Java_pc == NULL, "already walkable"); fails with async profiler [v2]

[David Holmes]

On Wed, 13 Apr 2022 06:42:56 GMT, Johannes Bechberger <duke at openjdk.java.net> wrote:

>> Fix the assertion by replacing it by assertion that does not fail.
>
> Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Do not alter JFA in sender_for_entry

Hi Johannes,

Sorry for the delay in getting back to you on this one (vacation).

With this change `JavaFrameAnchor::capture_last_Java_pc` is now only called from `JFA::make_walkable()` so it no longer needs to exist as a method. But I have to wonder why we have:

if (!jfa->walkable()) {
  // Capture _last_Java_pc (if needed) and mark anchor walkable.
  jfa->capture_last_Java_pc();
}

in the first place instead of simply:

if (!jfa->walkable()) {
  jfa->make_walkable();
}

  and the check of `walkable()` isn't even needed in that case.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8209