RFR: 8285364: Use more precise name for ReferenceType::REF_OTHER [v2]

Albert Mingkun Yang ayang at openjdk.java.net
Thu Apr 21 11:47:28 UTC 2022


On Thu, 21 Apr 2022 11:36:35 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

> Maybe the latter could be changed to REF_NONE?

`vmClasses::Reference_klass()->set_reference_type(REF_NONE);` fails in `make images`.

The relevant code is:


ClassFileParser::post_process_parsed_stream(...) {
  ...
  _rt = (NULL ==_super_klass) ? REF_NONE : _super_klass->reference_type();
}

InstanceKlass::allocate_instance_klass(...) {
  ...
  if (REF_NONE == parser.reference_type()) {
    ...
  } else {
    // reference
    ik = new (loader_data, size, THREAD) InstanceRefKlass(parser);
  }
}


The `else` branch is for non-strong refs and relies on the ref-type of their super klass not being `REF_NONE`.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8332


More information about the hotspot-dev mailing list