RFR: 8285342: Zero build failure with clang due to values not handled in switch [v2]
Andrew Haley
aph at openjdk.java.net
Thu Apr 21 16:36:29 UTC 2022
On Thu, 21 Apr 2022 11:09:23 GMT, Jie Fu <jiefu at openjdk.org> wrote:
>> src/hotspot/cpu/zero/zeroInterpreter_zero.cpp line 623:
>>
>>> 621: break;
>>> 622: default:
>>> 623: ;
>>
>> `ShouldNotReachHere()` ? Maybe an `assert()` ?
>
>> `ShouldNotReachHere()` ? Maybe an `assert()` ?
>
> We should not add `ShouldNotReachHere()` or `assert()` here.
> This is because the `entry->flag_state()` may be `itos/ftos...`.
> The logic is only add one more slot for long/double.
> So just do nothing here.
Eww, OK.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8330
More information about the hotspot-dev
mailing list