Integrated: 8283643: [AIX, testbug] MachCodeFramesInErrorFile test fails to find 'Native frames' text

Tyler Steele duke at openjdk.java.net
Tue Apr 26 15:28:55 UTC 2022


On Mon, 4 Apr 2022 15:47:06 GMT, Tyler Steele <duke at openjdk.java.net> wrote:

> I observed a failure of MachCodeFramesInErrorFile.java on AIX. The raised error complains that 'Native frames: ' is missing. To fix the failure, I made two changes to the test that allowed it to pass on AIX.
> 
> The first change made was to the test's `extractFrames` method. AIX overrides `os::platform_print_native_stack` with stack printing specific to AIX/Power. This code does not produce the 'Native frames: ' text that `vmError::print_native_stack` does, so the test was modified to expect the AIX output when run on AIX. [Edit: The changes made to `extractFrames` are now minimal. I made the change to `AixNativeCallstack::print_callstack_for_context` instead.]
> 
> A second change was made to the address passed to the `crashInNative1` method. AIX does not consider low-address memory to be protected as other platforms do. In fact, "the first 256 bytes are reserved for software use" according to the Power ISA. Accordingly, the read address for PPC was changed to -1 (0xFF..FF) to produce the expected failure result.
> 
> ### Testing
> 
> Tier1 tests complete as expected on AIX/Power.

This pull request has now been integrated.

Changeset: 97a0a292
Author:    Tyler Steele <tyler.steele at ibm.com>
Committer: Thomas Stuefe <stuefe at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/97a0a292a6950a3d0a7928d5ac439670c84f0dbe
Stats:     14 lines in 2 files changed: 4 ins; 2 del; 8 mod

8283643: [AIX, testbug] MachCodeFramesInErrorFile test fails to find 'Native frames' text

Reviewed-by: dnsimon, dholmes

-------------

PR: https://git.openjdk.java.net/jdk/pull/8094


More information about the hotspot-dev mailing list