RFR: 8282477: [x86, aarch64] vmassert(_last_Java_pc == NULL, "already walkable"); fails with async profiler [v3]

[David Holmes]

On Thu, 28 Apr 2022 10:55:29 GMT, Johannes Bechberger <duke at openjdk.java.net> wrote:

>> Fix the assertion by replacing it by assertion that does not fail.
>
> Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use make_walkable

General shape of the change looks okay.

Just one change below that leads to a broader query. :)

Thanks,
David

src/hotspot/cpu/aarch64/frame_aarch64.cpp line 835:

> 833: #endif
> 834: 
> 835: void JavaFrameAnchor::make_walkable(Thread* thread) {

No need to change the type of `thread`  (the later cast in the assert was unnecessary). 

Though why is the thread passed in as it is unused except in the assert??

-------------

Changes requested by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8209