RFR: 8282477: [x86, aarch64] vmassert(_last_Java_pc == NULL, "already walkable"); fails with async profiler [v3]

[Martin Doerr]

On Fri, 29 Apr 2022 06:38:47 GMT, Johannes Bechberger <duke at openjdk.java.net> wrote:

>> src/hotspot/cpu/aarch64/frame_aarch64.cpp line 835:
>> 
>>> 833: #endif
>>> 834: 
>>> 835: void JavaFrameAnchor::make_walkable(Thread* thread) {
>> 
>> No need to change the type of `thread`  (the later cast in the assert was unnecessary). 
>> 
>> Though why is the thread passed in as it is unused except in the assert??
>
>> Though why is the thread passed in as it is unused except in the assert??
> 
> I don't know. Removing it would clean up the code.

Right, I also noticed that. Unneeded `Thread::current()` calls are not nice, either. If we can live without the assertion I'd like to see the thread parameter go away.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8209