RFR: 8290840: Refactor the "os" class [v6]

Ioi Lam iklam at openjdk.org
Tue Aug 2 16:06:10 UTC 2022


> Please see [JDK-8290840](https://bugs.openjdk.org/browse/JDK-8290840) for the detailed proposal.
> 
> The `os` class, declared in os.hpp, forms the major part of the HotSpot porting interface. Its structure has gradually deteriorated over the years as new ports are created and new APIs are added.
> 
> This RFE tries to address the following:
> 
> - Clearly specify where a porting API should be declared and defined among the various `os*.cpp` and `os*.hpp` files.
> - Avoid the inappropriate inclusion of OS-specific APIs (such as the `os::Linux class`) by platform-independent source files.

Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 13 additional commits since the last revision:

 - clarified comments about inline functions declared in os.hpp
 - Merge branch 'master' into 8290840-refactor-the-os-class
 - made workaround_expand_exec_shield_cs_limit() static; added PPC comments for os::resolve_function_descriptor()
 - fixed whitespace
 - clarify comment
 - PLATFORM_PRINT_NATIVE_STACK -> HAVE_PLATFORM_PRINT_NATIVE_STACK
 - simplified rarely-defined function os::resolve_function_descriptor()
 - Made workaround_expand_exec_shield_cs_limit() a static function in os_linux.cpp
 - fixed typo
 - moved os::{print_active_locale, print_user_info} to os_posix.cpp
 - ... and 3 more: https://git.openjdk.org/jdk/compare/0c02a00c...b6e60a54

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/9600/files
  - new: https://git.openjdk.org/jdk/pull/9600/files/06ae96b9..b6e60a54

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=9600&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=9600&range=04-05

  Stats: 10587 lines in 497 files changed: 5791 ins; 3470 del; 1326 mod
  Patch: https://git.openjdk.org/jdk/pull/9600.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/9600/head:pull/9600

PR: https://git.openjdk.org/jdk/pull/9600


More information about the hotspot-dev mailing list