RFR: 8290840: Refactor the "os" class [v3]

Ioi Lam iklam at openjdk.org
Tue Aug 2 16:12:55 UTC 2022


On Tue, 2 Aug 2022 16:08:35 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> I see there are only a few examples for what I meant. Many inline functions return platform dependend values and those live in variables in shared code (e.g. os::vm_page_size(), ...). Others are just not inline (os.create_thread(), ...). Which leaves us with the likes of `zero_page_read_protected()` etc, and I see you put them into os.inline.hpp and there you include the OS specific headers too.
> 
> I guess this can mostly be avoided. E.g. there is zero reason why `zero_page_read_protected()` cannot be a static boolean variable in os. For future RFEs.

Yes, this can certainly be improved in follow-up RFE.

-------------

PR: https://git.openjdk.org/jdk/pull/9600


More information about the hotspot-dev mailing list