RFR: 8290025: Remove the Sweeper [v3]

Erik Österlund eosterlund at openjdk.org
Fri Aug 5 05:56:49 UTC 2022


On Thu, 4 Aug 2022 22:14:37 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>>> Initial review of few `code/` files. Will do more later.
>>> 
>>> I am not comfortable with name `unloading` for this process because historically, for me, it is associated with class unloading and "unloading" corresponding nmethods. `cleaning` is more similar with `sweeping`. But it could be only me.
>> 
>> Thanks for reviewing this change! I'm using the term "code cache unloading", because that is what we have always called unloading of nmethods triggered by the GC. And now it is the GC that owns this completely, so code cache unloading is the way in which nmethods are freed. At least that was my reasoning. I'd like to split the "unloading" parts of the CodeCache to a separate file, but I decided it's better to do that in a separate patch, as this patch is large enough and I don't want to move around code as well in it. Hope this makes sense.
>
>> > Initial review of few `code/` files. Will do more later.
>> > I am not comfortable with name `unloading` for this process because historically, for me, it is associated with class unloading and "unloading" corresponding nmethods. `cleaning` is more similar with `sweeping`. But it could be only me.
>> 
>> Thanks for reviewing this change! I'm using the term "code cache unloading", because that is what we have always called unloading of nmethods triggered by the GC. And now it is the GC that owns this completely, so code cache unloading is the way in which nmethods are freed. At least that was my reasoning. I'd like to split the "unloading" parts of the CodeCache to a separate file, but I decided it's better to do that in a separate patch, as this patch is large enough and I don't want to move around code as well in it. Hope this makes sense.
> 
> Okay, I agree since it is GC operation now.

Thanks for the review @vnkozlov

-------------

PR: https://git.openjdk.org/jdk/pull/9741


More information about the hotspot-dev mailing list