RFR: 8290025: Remove the Sweeper [v3]

Erik Österlund eosterlund at openjdk.org
Fri Aug 5 08:32:20 UTC 2022


On Fri, 5 Aug 2022 08:16:10 GMT, Axel Boldt-Christmas <duke at openjdk.org> wrote:

> There are a few comments that mention the sweeper as well.
> 
> * `src/hotspot/share/jvmci/jvmci.hpp:110`
>   
>   * `CodeInstallResult::nmethod_reclaimed` enum
>     
>     * This seems like it is dead code now, there does not look like there is any safepoint between the creation of the `nmethod` and the call to `make_in_use()` so it should return true always? Not looked to close at it. But regardless, feels like it should be at least noted that the `JVMCIRuntime::register_method` function should be looked at by someone in the future.

I removed the comment. It isn't dead code, nmethods can still be made not_entrant before being installed. Just not by the sweeper.

> * `src/hotspot/share/gc/shared/space.cpp:147`
>   
>   * Old code, maybe just the reference to the sweeper can be removed.

This is referring to the sweeping part of the mark and sweep algorithm. CMS (Concurrent Mark Sweep) did sweeping concurrently. It's a different thing. One might argue the comment should go, but not in this patch.

-------------

PR: https://git.openjdk.org/jdk/pull/9741


More information about the hotspot-dev mailing list