RFR: 8291752: AArch64: Remove check_emit_size parameter from trampoline_call [v2]

Evgeny Astigeevich duke at openjdk.org
Fri Aug 5 20:13:21 UTC 2022


On Fri, 5 Aug 2022 19:22:33 GMT, Evgeny Astigeevich <duke at openjdk.org> wrote:

>> src/hotspot/cpu/aarch64/nativeInst_aarch64.cpp line 541:
>> 
>>> 539:   // If we generated no stub, patch this call directly to dest.
>>> 540:   // This will happen if we don't need far branches or if there
>>> 541:   // already was a trampoline.
>> 
>> I think this comment should be changed since you changed the code.
>
> The original code looks strange to me.
> If we need a stub but we have failed to create it, we set dest anyway. This will lead to an incorrect instruction.
> The behaviour is undefined. We might fail executing the instruction or jump somewhere.

I've restored the original functionality.
Maybe Andrew(@theRealAph) can explain what should be here.

-------------

PR: https://git.openjdk.org/jdk/pull/9782


More information about the hotspot-dev mailing list