RFR: 8291459: JVM crash with GenerateOopMap::error_work(char const*, __va_list_tag*) [v3]

[Harold Seigel]

On Fri, 5 Aug 2022 13:44:05 GMT, Harold Seigel <hseigel at openjdk.org> wrote:

>> The JVM fails when generating oop maps for method getAlphanumericCode(int) in bug_file/com/google/zxing/qrcode/encoder/Encoder.javap because the last bytecode in the method is an unreachable conditional branch at byecode index 11131:
>> 
>>       11124: ireturn
>>       11125: iinc          41, 1
>>       11128: iload         41
>>       11130: iconst_2
>>       11131: if_icmple     291
>> 
>> The class file (Encoder.class) containing getAlphanumericCode(int) has a class file version of 49.  So it is verified by the old verifier, which allows methods to end in a conditional branch provided that the conditional branch is unreachable during method execution.
>> 
>> This fix changes GenerateOopMap::jump_targets_do() to handle such methods.
>> 
>> The fix was tested by running the user's failing program, the new regression test, Mach5 tiers 1-2 on Linux, Mac OS, and Windows, Mach5 tiers 3-5 on Linu x64, and the JC Lang,VM, and API tests locally on Linux x64.
>> 
>> Please review.
>> Thanks, Harold
>
> Harold Seigel has updated the pull request incrementally with one additional commit since the last revision:
> 
>   remove packages from test classes

Thanks David and Coleen for the reviews.

-------------

PR: https://git.openjdk.org/jdk/pull/9745