RFR: 8292016: Rework JLI_ReportErrorMessageSys [v7]

Julian Waters jwaters at openjdk.org
Mon Aug 8 12:29:09 UTC 2022


On Mon, 8 Aug 2022 09:06:39 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   I feel stupid
>
> src/java.base/unix/native/libjli/java_md_common.c line 209:
> 
>> 207:     /*
>> 208:      * TODO: its safer to use strerror_r but is not available on
>> 209:      * Solaris 8. Until then....
> 
> We are well past then :) so this should be changed to use strerror_r - though see ./java.base/unix/native/libjava/jni_util_md.c

Looks like the names in jni_util_md.c are also hopelessly inaccurate - what would equate to strlen(strerror_r(errno)) and returns a size_t is named getLastErrorString :P

-------------

PR: https://git.openjdk.org/jdk/pull/9793


More information about the hotspot-dev mailing list