RFR: 8292007: Do not include vmSymbol.hpp in method.hpp

Coleen Phillimore coleenp at openjdk.org
Tue Aug 9 12:39:18 UTC 2022


On Sat, 6 Aug 2022 02:04:42 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> A small build speed improvement:
> 
> The popular header method.hpp has this inline function
> 
> 
> bool is_continuation_enter_intrinsic() const {
>   return intrinsic_id() == vmIntrinsics::_Continuation_enterSpecial;
> }
> 
> 
> which causes the large header files vmSymbols.hpp and vmIntrinsics.hpp to be unnecessarily included by many HotSpot object files.
> 
> The fix is to move this function to method.inline.hpp.
> 
> (It might be performance critical since it's used by some loops that walk the call frames).

Looks good.  GHA likes it so it can be deemed trivial.

-------------

Marked as reviewed by coleenp (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9789


More information about the hotspot-dev mailing list