RFR: 8292068: Convert ModuleEntryTable into ResourceHashtable

Coleen Phillimore coleenp at openjdk.org
Wed Aug 10 12:49:31 UTC 2022


On Wed, 10 Aug 2022 12:15:56 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> src/hotspot/share/classfile/moduleEntry.cpp line 595:
>> 
>>> 593: // lookup_only by Symbol* to find a ModuleEntry.
>>> 594: ModuleEntry* ModuleEntryTable::lookup_only(Symbol* name) {
>>> 595:   assert_locked_or_safepoint(Module_lock);
>> 
>> Is it true that all public functions in the ModuleEntryTable class require the Module_lock to be held? If so, maybe this should be documented in the class declaration, and the assert to be added to all the functions.
>
> It is true, but wasn't true when the ModuleTable first was developed.  I'll add the asserts.

As suspected, there are places where we should have added taking the Module_lock.

-------------

PR: https://git.openjdk.org/jdk/pull/9809


More information about the hotspot-dev mailing list