RFR: 8292218: Convert PackageEntryTable to ResourceHashtable
Lois Foltan
lfoltan at openjdk.org
Thu Aug 11 16:15:41 UTC 2022
On Thu, 11 Aug 2022 12:20:47 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
> This is the conversion of the PackageEntryTable, which is stored one per ClassLoaderData to ResourceHashtable. Much like the module table and uses the Module_lock.
> Tested with tier1-3 on linux, windows, mac.
src/hotspot/share/classfile/packageEntry.cpp line 202:
> 200: log_info(module, unload)("unloading package %s", str);
> 201: log_debug(module)("PackageEntry: deleting module: %s", str);
> 202: }
Not "deleting module" but "deleting package"
src/hotspot/share/classfile/packageEntry.cpp line 283:
> 281: int n = 0;
> 282: auto count = [&] (const Symbol*& key, PackageEntry*& p) {
> 283: if (p->module()->name() != NULL) {
The better way to check for the unnamed module is to use the ModuleEntry::is_named() method.
src/hotspot/share/classfile/packageEntry.cpp line 293:
> 291: n = 0;
> 292: auto grab = [&] (const Symbol*& key, PackageEntry*& p) {
> 293: if (p->module()->name() != NULL) {
The better way to check for the unnamed module is to use the ModuleEntry::is_named() method
-------------
PR: https://git.openjdk.org/jdk/pull/9837
More information about the hotspot-dev
mailing list