RFR: 8292218: Convert PackageEntryTable to ResourceHashtable [v2]

Lois Foltan lfoltan at openjdk.org
Thu Aug 11 20:15:08 UTC 2022


On Thu, 11 Aug 2022 19:15:45 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> This is the conversion of the PackageEntryTable, which is stored one per ClassLoaderData to ResourceHashtable.  Much like the module table and uses the Module_lock.
>> Tested with tier1-3 on linux, windows, mac.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix debug info and module name comparison.

Thanks Coleen, looks good.  I've added just one more minor comment.
Lois

src/hotspot/share/classfile/packageEntry.cpp line 201:

> 199:         const char* str = name->as_C_string();
> 200:         log_info(module, unload)("unloading package %s", str);
> 201:         log_debug(module)("PackageEntry: deleting package: %s", str);

A real nit but to be consistent with ModuleEntryTable::~ModuleEntryTable() maybe change "PackageEntry:" to "PackageEntryTable:"

-------------

Marked as reviewed by lfoltan (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9837


More information about the hotspot-dev mailing list