RFR: 8292194: G1 nmethod entry barrier disarm value wraps around too early

Erik Österlund eosterlund at openjdk.org
Mon Aug 15 09:56:25 UTC 2022


On Mon, 15 Aug 2022 09:21:09 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> The disarm value for G1 nmethod entry barriers assumes that a concurrent GC can be aborted at most once. However, it can happen many times. In order to avoid ABA issues in the nmethod entry barriers, the limit for wrapping around and reusing numbers needs to be higher. This patch changes that point to INT_MAX as there is little point in using lower values.
>
> Looks good. Though, it's unclear to me why the counter is signed in the first place.

Thanks for the review, @albertnetymk!

-------------

PR: https://git.openjdk.org/jdk/pull/9822


More information about the hotspot-dev mailing list