RFR: 8292448: Convert BitMapFragmentTable to ResourceHashtable [v2]

Ioi Lam iklam at openjdk.org
Tue Aug 16 20:55:22 UTC 2022


On Tue, 16 Aug 2022 16:10:15 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> This is an uncomplicated conversion of the bitmap fragment table into a ResizeableResourceHashtable.  Ran tiers 1-3 and 4-7 with other changes, and verified that the memory for ResourceHashtableStorage is freed.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove mtTracing old Hashtable instantiation.

Looks good, but I think the explicit delete is not necessary.

src/hotspot/share/utilities/objectBitSet.inline.hpp line 63:

> 61:   };
> 62:   Deleter deleter;
> 63:   _bitmap_fragments.unlink(&deleter);

This shouldn't be necessary. The destructor of _bitmap_fragments will be implicitly called and will free all of its entries.

-------------

PR: https://git.openjdk.org/jdk/pull/9893


More information about the hotspot-dev mailing list