RFR: 8292203: AArch64: Represent Registers as values [v2]
Vladimir Ivanov
vlivanov at openjdk.org
Wed Aug 17 18:29:20 UTC 2022
On Mon, 15 Aug 2022 10:26:07 GMT, Quan Anh Mai <duke at openjdk.org> wrote:
>> Vladimir Ivanov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:
>>
>> - Merge branch 'master' into rwrapper.aarch64
>> - 8292203: AArch64: Represent Registers as values
>> - cleanups
>> - x86: Register class wrappers
>
> src/hotspot/cpu/aarch64/register_aarch64.hpp line 39:
>
>> 37: int _encoding;
>> 38:
>> 39: constexpr Register(int encoding, bool unused) : _encoding(encoding) {}
>
> Why do we need unused here? If the intention is to prevent implicit conversion from `int` to `Register` then you can mark the constructor as `explicit`. Thanks.
Good point. Fixed.
-------------
PR: https://git.openjdk.org/jdk/pull/9826
More information about the hotspot-dev
mailing list