RFR: 8292446: Make TableRateStatistics optional in CHT [v2]

[Johan Sjölén]

On Wed, 17 Aug 2022 15:15:07 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Johan Sjölén has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Uninitialized pointers do not default to nullptr
>>  - Fixes
>
> src/hotspot/share/gc/g1/g1CardSet.cpp line 37:
> 
>> 35: #include "runtime/java.hpp"
>> 36: #include "utilities/bitMap.inline.hpp"
>> 37: #include "utilities/concurrentHashTable.hpp"
> 
> Do you needs this? Doesn't concurrentHashTable.inline.hpp include it already?

Fixed :).

> src/hotspot/share/utilities/concurrentHashTable.hpp line 399:
> 
>> 397:                       size_t grow_hint = DEFAULT_GROW_HINT,
>> 398:                       void* context = nullptr,
>> 399:                       bool enable_statistics = DEFAULT_ENABLE_STATISTICS);
> 
> I wonder if it would be better to put context last since it's only used by one hashtable?

That did make things nicer!

-------------

PR: https://git.openjdk.org/jdk/pull/9899