RFR: 8292596: Make SymbolHashMap a ResourceHashtable

Coleen Phillimore coleenp at openjdk.org
Thu Aug 18 15:26:12 UTC 2022


On Thu, 18 Aug 2022 15:12:25 GMT, Harold Seigel <hseigel at openjdk.org> wrote:

>> Please review this straightforward change to use ResourceHashtable for SymbolHashMap, which is used by the Class File Reconstituter.  The table maps Symbol* to constant pool indices for loaded classes (Symbol refcounting unnecessary as the class is not unloaded because it's in use).
>> Tested with jvmti tests locally and tier 1-3.
>
> src/hotspot/share/oops/constantPool.hpp line 921:
> 
>> 919:  private:
>> 920:   // Default number of entries in the table
>> 921:   ResourceHashtable<const Symbol*, u2, 256, ResourceObj::C_HEAP, mtSymbol, Symbol::compute_hash> _table;
> 
> The comment at new line 920, about 'number of entries' is no longer is accurate.

Thank you for catching that.

-------------

PR: https://git.openjdk.org/jdk/pull/9917


More information about the hotspot-dev mailing list