RFR: 8292446: Make TableRateStatistics optional in CHT [v4]
Coleen Phillimore
coleenp at openjdk.org
Thu Aug 18 19:20:08 UTC 2022
On Thu, 18 Aug 2022 09:22:15 GMT, Johan Sjölén <duke at openjdk.org> wrote:
>> Right now the footprint of disabling statistics for tables where they're not used is minimal as they're single instance and static. We're working on using CHT in more contexts, where it will be dynamically allocated, and then these changes will add up to something more substantial.
>>
>> Passes tier1+tier2
>
> Johan Sjölén has updated the pull request incrementally with one additional commit since the last revision:
>
> Declare functions inline
src/hotspot/share/utilities/concurrentHashTable.hpp line 394:
> 392: static const size_t DEFAULT_START_SIZE_LOG2 = 13;
> 393: static const size_t DEFAULT_GROW_HINT = 4; // Chain length
> 394: static const bool DEFAULT_ENABLE_STATISTICS = true;
Ok, one last thing. I wonder if we should default to false for enabling table rate statistics? Only the StringTable and SymbolTable need it.
-------------
PR: https://git.openjdk.org/jdk/pull/9899
More information about the hotspot-dev
mailing list