RFR: JDK-8292351: tty should always live [v4]
Coleen Phillimore
coleenp at openjdk.org
Fri Aug 19 12:50:32 UTC 2022
On Wed, 17 Aug 2022 09:30:48 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
>> The default stream object tty is used in many places but its lifetime is limited. It gets born not-quite at the beginning of VM initialization and dies in DestroyVM. This leaves time windows before VM initialization and after VM cleanup where logging to tty crashes.
>>
>> This has been bugging me in the past, especially when wanting to use tty in code that runs very early (NMT preinit system, for example), and also causes problems for code that runs post-cleanup. Mostly this affects logging and error logging.
>>
>> tty should always be safe to write to, and that is trivial to do.
>
> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>
> Change comment
I think this is fine as a last chance handler. If we do need pre-init and post-exit logging, ie things come out to this output, we can re-evaluate and move the defaultStream destructor later or have some pre-init logging functionality. This seems good for reliably getting bug reports but should rarely be needed. If you find otherwise, please file an RFE.
-------------
Marked as reviewed by coleenp (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9874
More information about the hotspot-dev
mailing list