RFR: 8292564: x86: Remove redundant casts in Assembler usages [v2]

Aleksey Shipilev shade at openjdk.org
Fri Aug 19 13:36:35 UTC 2022


On Thu, 18 Aug 2022 16:41:16 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Clean up Assembler API and remove redundant at use sites.
>>  
>> They are not needed anymore because implicit casts between Register and integrals are forbidden now.
>> 
>> Some of the casts are turned into `static_cast`s to assert that constants are small enough to fit into 32-bit immediate.
>> 
>> Testing: hs-tier1 - hs-tier4
>
> Vladimir Ivanov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   checked_cast

Looks fine. I also tested with Alpine builds, that are known to get funky with `intptr_t` conversions.

-------------

Marked as reviewed by shade (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9909


More information about the hotspot-dev mailing list