RFR: 8292638: x86: Improve scratch register handling in VM stubs [v3]
Vladimir Kozlov
kvn at openjdk.org
Fri Aug 19 20:04:53 UTC 2022
On Thu, 18 Aug 2022 23:01:46 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:
>> (PR depends on #9923.)
>>
>> Constants which reside outside code cache are not guaranteed to be reachable in
>> RIP-relative addressing mode from stub code, but absolute addressing mode requires a
>> scratch register.
>>
>> Provide a scratch register to ensure constants are reachable irrespective of
>> process memory layout.
>>
>> Make scratch register usage explicit to make possible conflicts with surrounding stub code explicit.
>>
>> Testing:
>> - [x] hs-tier1 - hs-tier4
>> - [x] x86_32 hotspot build
>
> Vladimir Ivanov has updated the pull request incrementally with one additional commit since the last revision:
>
> rscratch
Looks good.
I would suggest to run full tier1-4 mach5 testing (instead of only hs-tier*) which will run java/lang/math tests too. And tier4 runs with -Xcomp.
-------------
PR: https://git.openjdk.org/jdk/pull/9932
More information about the hotspot-dev
mailing list